Skip to content

[G-API]: Fix coverity warnings#19044

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
OrestChura:oc/fix_coverity_warn_kmeans
Dec 8, 2020
Merged

[G-API]: Fix coverity warnings#19044
opencv-pushbot merged 1 commit intoopencv:masterfrom
OrestChura:oc/fix_coverity_warn_kmeans

Conversation

@OrestChura
Copy link
Copy Markdown
Contributor

@OrestChura OrestChura commented Dec 8, 2020

These changes move G-API output to the first place of arguments in comparison functions in some tests to make them consistent and eliminate warnings from coverity tool.

@alalek 's comment reference.

With the changes in indicated kmean's tests, I'm taking courage to edit older but similar places in code I introduced some time ago.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

Xbuild_image:Custom=ubuntu-openvino-2020.3.0:16.04
Xbuild_image:Custom Win=openvino-2020.3.0
Xbuild_image:Custom Mac=openvino-2020.3.0

test_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@OrestChura OrestChura requested a review from alalek December 8, 2020 00:07
@OrestChura OrestChura mentioned this pull request Dec 8, 2020
Merged
5 tasks
alalek
alalek approved these changes Dec 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you!

@opencv-pushbot opencv-pushbot merged commit 619cc01 into opencv:master Dec 8, 2020
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug category: g-api / gapi test

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@OrestChura @alalek @opencv-pushbot