Skip to content

Fixed minor typo "poins" in documentation page#18992

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
vertexcite:patch-1
Dec 3, 2020
Merged

Fixed minor typo "poins" in documentation page#18992
opencv-pushbot merged 1 commit intoopencv:3.4from
vertexcite:patch-1

Conversation

@vertexcite
Copy link
Copy Markdown
Contributor

@vertexcite vertexcite commented Dec 2, 2020 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-requested a review December 2, 2020 08:06
@asmorkalov asmorkalov self-assigned this Dec 2, 2020
@asmorkalov asmorkalov added category: documentation Documentation fix or update pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch labels Dec 2, 2020
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Dec 2, 2020

This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no need to re-open PR, apply changes "inplace".

@asmorkalov asmorkalov changed the base branch from master to 3.4 December 3, 2020 09:47
@asmorkalov asmorkalov removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Dec 3, 2020
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Dec 3, 2020

@vertexcite I helped you to rebase your patch to 3.4 and re-wrote git history in patch-1 branch.

asmorkalov
asmorkalov approved these changes Dec 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@opencv-pushbot opencv-pushbot merged commit 6502737 into opencv:3.4 Dec 3, 2020
@alalek alalek mentioned this pull request Dec 4, 2020
Merged
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.13

Development

Successfully merging this pull request may close these issues.

4 participants

@vertexcite @asmorkalov @opencv-pushbot @alalek