Aruco javascript fix and added functionality#18985
Conversation
|
Issue: #15514 |
|
Corresponding PR in opencv/opencv_contrib#2769 |
|
Hi, @urbste, can you please resolve merge conflicts and consider comments? Thansk! |
|
Please resolve merge conflicts - rebase with the latest master branch |
… into feature/aruco_js_fix
… into feature/aruco_js_fix
|
How do I resolve the merge conflicts. Sorry I am not that fit with git rebase from a remote? I did git fetch origin
git rebase origin/masterHowever nothing really happened. And locally I do not get the merge conflicts. What am I doing wrong? |
|
Try the following:
|
|
Thanks for the tips. Still got problems. I did: git remote -v
origin https://github.com/urbste/opencv (fetch)
origin https://github.com/urbste/opencv (push)
upstream https://github.com/opencv/opencv (fetch)
upstream https://github.com/opencv/opencv (push)origin was not opencv/opencv. So I did git remote set-url origin https://github.com/opencv/opencv
git checkout master
git pull origin HEAD
git rebase master feature/aruco_js_fix
git mergetool
git rebase --continue
However, I only had one conflict in the documentation file, not the emdingen.py as indicated here on github. So something is still wrong I guess... :( This is not working: git push fork feature/aruco_js_fix -f
fatal: 'fork' does not appear to be a git repositorySorry for the inconveniece. :/ |
|
Ok I think I found a solution. I did not rebase but merge the master into my branch. |
|
@urbste, instead of "fork" you had to write your fork name. Anyway, now it's OK. |
|
@dkurt I do have some more significant changes in the Aruco module, that we would also like to share with the community. I still have forked the repositories in my github account. However I would like to transfer the repositories to my companies github team. Do you know if this PR will be influenced by that? |
|
@urbste, aruco module is located in a separate repository. |
|
I think this issue is also related to this PR: opencv/opencv_contrib#2526 |
Pull Request Readiness Checklist
resolves opencv/opencv_contrib#2526
resolves #15514
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.