Skip to content

GAPI: fix C++17 compilation errors in GNetPackage #18981

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
anton-potapov:fix_gnet_package_compilation_std_17
Dec 1, 2020
Merged

GAPI: fix C++17 compilation errors in GNetPackage #18981
opencv-pushbot merged 1 commit intoopencv:masterfrom
anton-potapov:fix_gnet_package_compilation_std_17

Conversation

@anton-potapov
Copy link
Copy Markdown
Contributor

  • explicitly declared default constructor
  • made initilizer_list  constructor to accept the list by copy
       -- as it is  more canonical (and as copying the initializer_list does
    not force copy of the list items)
       -- current version anyway does not do what it is intended to

(fixes #17385)

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

force_builders=ARMv7,Custom
build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

- explicitly declared default constructor
- made initilizer_list  constructor to accept the list by copy
   -- as it is  more canonical (and as copying the initializer_list does
not force copy of the list items)
   -- current version anyway does not do what it is intended to
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@opencv-pushbot opencv-pushbot merged commit ef0eed8 into opencv:master Dec 1, 2020
@alalek alalek mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure with GCC C++17 due to GNetPackage constructor

5 participants