Skip to content

Delete xcframework if it already exists before building a new one#18972

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
Rightpoint:task/colejd/prevent-existing-xcframework-error
Dec 1, 2020
Merged

Delete xcframework if it already exists before building a new one#18972
opencv-pushbot merged 1 commit intoopencv:masterfrom
Rightpoint:task/colejd/prevent-existing-xcframework-error

Conversation

@colejd
Copy link
Copy Markdown
Contributor

@colejd colejd commented Nov 30, 2020

Right now, if you build an xcframework and the destination xcframework path already exists, xcodebuild will throw an error complaining about this. This happens very late in the whole process, which is troublesome. This PR resolves this issue by deleting the xcframework if it already exists prior to building.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@colejd colejd force-pushed the task/colejd/prevent-existing-xcframework-error branch from 810cf7f to 69e1167 Compare November 30, 2020 21:53
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@opencv-pushbot opencv-pushbot merged commit fc54853 into opencv:master Dec 1, 2020
@colejd colejd deleted the task/colejd/prevent-existing-xcframework-error branch December 11, 2020 21:21
@alalek alalek mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants