Skip to content

Fixed issue with Epipolar Geometry Tutorial#18848

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
IanMaquignaz:fixEpipolarGeometryTutorial
Nov 19, 2020
Merged

Fixed issue with Epipolar Geometry Tutorial#18848
opencv-pushbot merged 1 commit intoopencv:3.4from
IanMaquignaz:fixEpipolarGeometryTutorial

Conversation

@IanMaquignaz
Copy link
Copy Markdown
Contributor

@IanMaquignaz IanMaquignaz commented Nov 18, 2020 •
edited by alalek
Loading

Fixes #18847

Code validated. Result matches anticipated.

Rectified Image Pair:
Figure_1

Image Pair:
Figure_2

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Copy Markdown
Member

alalek commented Nov 18, 2020

Thank you for contribution!

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@IanMaquignaz
Copy link
Copy Markdown
Contributor Author

IanMaquignaz commented Nov 18, 2020

PS C:\workspace\opencv-dev> git rebase -i --onto upstream/3.4 upstream/master
Successfully rebased and updated refs/heads/fixEpipolarGeometryTutorial.
PS C:\workspace\opencv-dev> git push --force
Everything up-to-date
PS C:\workspace\opencv-dev>

I think it's done?

@IanMaquignaz IanMaquignaz force-pushed the fixEpipolarGeometryTutorial branch from 6f5c507 to fef2376 Compare November 18, 2020 17:35
alalek
alalek approved these changes Nov 19, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 599bb9c into opencv:3.4 Nov 19, 2020
@IanMaquignaz IanMaquignaz deleted the fixEpipolarGeometryTutorial branch November 19, 2020 22:13
This was referenced Nov 20, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: calib3d category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.13

Development

Successfully merging this pull request may close these issues.

Error in Epipolar Geometry Tutorial

3 participants

@IanMaquignaz @alalek @opencv-pushbot