Skip to content

add rudimentary support for uEye cameras#18756

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
andy-held:add_ueye_capture
Nov 16, 2020
Merged

add rudimentary support for uEye cameras#18756
opencv-pushbot merged 1 commit intoopencv:masterfrom
andy-held:add_ueye_capture

Conversation

@andy-held
Copy link
Copy Markdown
Contributor

uEye are cameras from IDS, c.f. https://en.ids-imaging.com/
Only supports the newest driver 4.94 since the event system was overhauled in the latest version, which made this implementation considerably shorter.

Already works on Linux, I want to add support for Windows and some basic properties before merging.
I would like to get some early feedback, if possible.

Pull Request Readiness Checklist

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@andy-held andy-held force-pushed the add_ueye_capture branch 2 times, most recently from 4c0c538 to 3296825 Compare November 9, 2020 23:50
@andy-held andy-held marked this pull request as draft November 9, 2020 23:51
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good

@andy-held andy-held force-pushed the add_ueye_capture branch 2 times, most recently from 5ced1c6 to a848511 Compare November 13, 2020 12:29
@andy-held andy-held marked this pull request as ready for review November 13, 2020 12:33
@andy-held
Copy link
Copy Markdown
Contributor Author

squashed commits, better commit message

uEye are cameras from IDS, c.f. https://en.ids-imaging.com/
Supports driver version 4.94 and up currently, since the event system was overhauled there.
Supports setting/getting the properties: fps,width,height
@andy-held
Copy link
Copy Markdown
Contributor Author

Builds for win/mac were not queued correctly in CI, changed the commit hash to force rebuild.

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you for contribution 👍

@opencv-pushbot opencv-pushbot merged commit b4b2a27 into opencv:master Nov 16, 2020
@andy-held
Copy link
Copy Markdown
Contributor Author

thank you for the quality review :-)

@andy-held andy-held deleted the add_ueye_capture branch November 20, 2020 20:10
@alalek alalek mentioned this pull request Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants