Skip to content

Fixed Inputs/OutputsDataMap conversion#18742

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
AsyaPronina:asyadev/fix_preprocessing_for_import_network
Nov 6, 2020
Merged

Fixed Inputs/OutputsDataMap conversion#18742
opencv-pushbot merged 1 commit intoopencv:masterfrom
AsyaPronina:asyadev/fix_preprocessing_for_import_network

Conversation

@AsyaPronina
Copy link
Copy Markdown
Contributor

@AsyaPronina AsyaPronina commented Nov 6, 2020 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

Xbuild_image:Custom=ubuntu-openvino-2020.3.0:16.04
build_image:Custom Win=openvino-2020.3.0
build_image:Custom Mac=openvino-2020.3.0

Xtest_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi

Xbuildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
Xtest_opencl:Custom=OFF
Xtest_bigdata:Custom=1
Xtest_filter:Custom=*

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

TolyaTalamanov commented Nov 6, 2020

👍 Thanks!

@AsyaPronina AsyaPronina mentioned this pull request Nov 6, 2020
Closed
6 tasks
@AsyaPronina AsyaPronina requested a review from dmatveev November 6, 2020 11:15
dmatveev
dmatveev approved these changes Nov 6, 2020
View reviewed changes
modules/gapi/src/backends/ie/giebackend/giewrapper.cpp
@@ -25,7 +25,7 @@ using GIEParam = cv::gapi::ie::detail::ParamDesc;
IE::InputsDataMap giewrap::toInputsDataMap (const IE::ConstInputsDataMap& inputs) {
IE::InputsDataMap transformed;
auto convert = [](const std::pair<std::string, IE::InputInfo::CPtr>& p) {
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev Nov 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert is not a good name here, I believe. In fact, you're not converting anything.

I'd rename it /in some further PR/ (now take it to the issue tracker)

@AsyaPronina AsyaPronina force-pushed the asyadev/fix_preprocessing_for_import_network branch from 87c518f to 5786df2 Compare November 6, 2020 11:25
@AsyaPronina AsyaPronina changed the title Fixed Inputs/OutputsDataMap convertion Fixed Inputs/OutputsDataMap conversion Nov 6, 2020
@AsyaPronina AsyaPronina force-pushed the asyadev/fix_preprocessing_for_import_network branch from 7357447 to a410afc Compare November 6, 2020 11:54
@dmatveev dmatveev self-assigned this Nov 6, 2020
@dmatveev dmatveev added this to the 4.5.1 milestone Nov 6, 2020
@AsyaPronina AsyaPronina force-pushed the asyadev/fix_preprocessing_for_import_network branch from a410afc to ec5065e Compare November 6, 2020 12:45
@opencv-pushbot opencv-pushbot merged commit e12adcd into opencv:master Nov 6, 2020
@alalek alalek mentioned this pull request Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

@TolyaTalamanov TolyaTalamanov TolyaTalamanov approved these changes

@rgarnov rgarnov rgarnov approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

5 participants

@AsyaPronina @TolyaTalamanov @dmatveev @rgarnov @opencv-pushbot