Fixed undefined rmat and media symbols in standalone#18740
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Nov 6, 2020
Merged
Fixed undefined rmat and media symbols in standalone#18740opencv-pushbot merged 1 commit intoopencv:masterfrom
opencv-pushbot merged 1 commit intoopencv:masterfrom
Conversation
rgarnov
commented
Nov 5, 2020
| "${FLUID_ROOT}/include/opencv2/gapi/fluid/*.hpp") | ||
| file(GLOB FLUID_sources "${FLUID_ROOT}/src/api/g*.cpp" | ||
| "${FLUID_ROOT}/src/api/rmat.cpp" | ||
| "${FLUID_ROOT}/src/api/media.cpp" |
Contributor
Author
There was a problem hiding this comment.
Maybe it's worth to add a new directory for own types which can be on computation input/output
Contributor
There was a problem hiding this comment.
Let's put it to our wishlist
dmatveev
approved these changes
Nov 6, 2020
| "${FLUID_ROOT}/include/opencv2/gapi/fluid/*.hpp") | ||
| file(GLOB FLUID_sources "${FLUID_ROOT}/src/api/g*.cpp" | ||
| "${FLUID_ROOT}/src/api/rmat.cpp" | ||
| "${FLUID_ROOT}/src/api/media.cpp" |
Contributor
There was a problem hiding this comment.
Let's put it to our wishlist
Contributor
|
@alalek can this merge be prioritized? we really missed this fix for our upcoming internal drop :) |
Contributor
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.