Skip to content

Added support of 1x1x1xN input for parseYolo#18729

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
rgarnov:rg/extend_parse_yolo
Nov 13, 2020
Merged

Added support of 1x1x1xN input for parseYolo#18729
opencv-pushbot merged 1 commit intoopencv:masterfrom
rgarnov:rg/extend_parse_yolo

Conversation

@rgarnov
Copy link
Copy Markdown
Contributor

@rgarnov rgarnov commented Nov 4, 2020 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

@rgarnov rgarnov requested a review from AsyaPronina November 4, 2020 23:29
@rgarnov rgarnov force-pushed the rg/extend_parse_yolo branch 3 times, most recently from 15df1ee to 7992419 Compare November 11, 2020 09:59
@rgarnov rgarnov force-pushed the rg/extend_parse_yolo branch from 7992419 to 5d5898d Compare November 12, 2020 13:50
AsyaPronina
AsyaPronina reviewed Nov 12, 2020
View reviewed changes
@rgarnov rgarnov force-pushed the rg/extend_parse_yolo branch from 5d5898d to 834a331 Compare November 13, 2020 10:26
@rgarnov rgarnov requested review from alalek and removed request for alalek November 13, 2020 13:00
alalek
alalek reviewed Nov 13, 2020
View reviewed changes
modules/gapi/src/backends/cpu/gnnparsers.cpp Outdated
GAPI_Assert(d[i] == 1);
}
} else {
checkOneDimCase();
Copy link
Copy Markdown
Member

@alalek alalek Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can avoid lambda (looks bad in assertion messages) and expand its content below if you put return after for.

Also you may want to cache d.dims(): const int d = d.dims()

Copy link
Copy Markdown
Contributor Author

@rgarnov rgarnov Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@alalek
Copy link
Copy Markdown
Member

alalek commented Nov 13, 2020

@dmatveev If you want to delegate final merge "approval" then please "assign" PR on corresponding reviewer (you can do even before receiving "approved" status).
In that case I would not wait for your approval for PR.

@rgarnov rgarnov force-pushed the rg/extend_parse_yolo branch from 834a331 to 4e67a3c Compare November 13, 2020 13:20
@rgarnov rgarnov force-pushed the rg/extend_parse_yolo branch from 4e67a3c to 0e4b5b8 Compare November 13, 2020 13:21
@opencv-pushbot opencv-pushbot merged commit 41e906d into opencv:master Nov 13, 2020
@alalek alalek mentioned this pull request Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

@AsyaPronina AsyaPronina AsyaPronina approved these changes

Assignees

@AsyaPronina AsyaPronina

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@rgarnov @alalek @AsyaPronina @opencv-pushbot