Skip to content

Change naming of keypoints comparator#18724

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
S-o-T:fix_confusing_naming_for_keypoints_comparator
Nov 3, 2020
Merged

Change naming of keypoints comparator#18724
opencv-pushbot merged 1 commit intoopencv:3.4from
S-o-T:fix_confusing_naming_for_keypoints_comparator

Conversation

@S-o-T
Copy link
Copy Markdown
Contributor

@S-o-T S-o-T commented Nov 3, 2020

Implementation (and usage in context of std::partition) of KeypointResponseGreaterThanThreshold does actually compare a keypoint with given threshold by greatness OR equality.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@opencv-pushbot opencv-pushbot merged commit 24d60da into opencv:3.4 Nov 3, 2020
@S-o-T S-o-T deleted the fix_confusing_naming_for_keypoints_comparator branch November 4, 2020 09:12
@alalek alalek mentioned this pull request Nov 5, 2020
@alalek alalek mentioned this pull request Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants