Skip to content

Added ND GMatDesc serialization test#18688

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
rgarnov:rg/add_gmatdesc_s11n_nd_test
Nov 16, 2020
Merged

Added ND GMatDesc serialization test#18688
opencv-pushbot merged 1 commit intoopencv:masterfrom
rgarnov:rg/add_gmatdesc_s11n_nd_test

Conversation

@rgarnov
Copy link
Copy Markdown
Contributor

@rgarnov rgarnov commented Oct 28, 2020 •
edited by alalek
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2020.3.0:16.04
build_image:Custom Win=openvino-2020.3.0
build_image:Custom Mac=openvino-2020.3.0

test_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@rgarnov rgarnov requested a review from dbudniko October 28, 2020 19:08
@rgarnov
Copy link
Copy Markdown
Contributor Author

rgarnov commented Nov 2, 2020

@dbudniko please take a look when you have time

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Nov 12, 2020

@dbudniko Friendly reminder.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Nov 16, 2020

@dmatveev The solution looks good to me. Could we merge the patch?

@rgarnov rgarnov force-pushed the rg/add_gmatdesc_s11n_nd_test branch from fb690f9 to 58268b6 Compare November 16, 2020 10:04
@dmatveev dmatveev added this to the 4.5.1 milestone Nov 16, 2020
@dmatveev dmatveev self-assigned this Nov 16, 2020
@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Nov 16, 2020

Approved, thanks

@opencv-pushbot opencv-pushbot merged commit e4a9ad1 into opencv:master Nov 16, 2020
@alalek alalek mentioned this pull request Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

@dbudniko dbudniko Awaiting requested review from dbudniko

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi test

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

5 participants

@rgarnov @asmorkalov @dmatveev @opencv-pushbot @alalek