Skip to content

[G-API] Minor s11n and RMat improvements:#18671

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
rgarnov:rg/rmat_and_s11n_fixes
Oct 28, 2020
Merged

[G-API] Minor s11n and RMat improvements:#18671
opencv-pushbot merged 1 commit intoopencv:masterfrom
rgarnov:rg/rmat_and_s11n_fixes

Conversation

@rgarnov
Copy link
Copy Markdown
Contributor

@rgarnov rgarnov commented Oct 27, 2020

Summart

  • Changed descr_of(RMat) to use canDescribeHelper to correctly handle planar case
  • Added export of createMat
  • Added setting of Storage::INPUT and Storage::OUTPUT in deserialization routine of GComputation

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

Xbuild_image:Custom=ubuntu-openvino-2020.3.0:16.04
Xbuild_image:Custom Win=openvino-2020.3.0
Xbuild_image:Custom Mac=openvino-2020.3.0

test_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

 - Changed descr_of(RMat) to use canDescribeHelper to correctly handle planar case
 - Added export of createMat
 - Added setting of Storage::INPUT and Storage::OUTPUT in deserialization routine of GComputation
@rgarnov rgarnov requested a review from dmatveev October 27, 2020 16:30
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 approved! Thanks for a quick turn-around!

@dmatveev dmatveev added this to the 4.5.1 milestone Oct 27, 2020
@dmatveev dmatveev self-assigned this Oct 27, 2020
@opencv-pushbot opencv-pushbot merged commit 209f6cd into opencv:master Oct 28, 2020
@alalek alalek mentioned this pull request Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants