Skip to content

fixes #18613#18614

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
ZhiyuanChen:patch-1
Oct 19, 2020
Merged

fixes #18613#18614
opencv-pushbot merged 1 commit intoopencv:3.4from
ZhiyuanChen:patch-1

Conversation

@ZhiyuanChen
Copy link
Copy Markdown
Contributor

@ZhiyuanChen ZhiyuanChen commented Oct 18, 2020

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@ZhiyuanChen
Copy link
Copy Markdown
Contributor Author

ZhiyuanChen commented Oct 18, 2020

Hi, I'm the current maintainer of PySOT (the original repor of siamrpnpp)
This file has many differences compared to the existing dasiamrpn.py, while they are actually very similar algorithm.
I think it would be better if we create a 'tracker' dir under https://github.com/opencv/opencv/blob/master/samples/dnn/ , and move both file inside, so that we could make them share a utils.py which generate anchors etc.

@alalek
Copy link
Copy Markdown
Member

alalek commented Oct 19, 2020

/cc @l-bat @bhack @ieliz Could you please take a look on this?

@bhack
Copy link
Copy Markdown

bhack commented Oct 19, 2020

/cc @jinyup100

@bhack
Copy link
Copy Markdown

bhack commented Oct 19, 2020

This file has many differences compared to the existing dasiamrpn.py, while they are actually very similar algorithm.
I think it would be better if we create a 'tracker' dir under https://github.com/opencv/opencv/blob/master/samples/dnn/ , and move both file inside, so that we could make them share a utils.py which generate anchors etc.

@ZhiyuanChen I think it is ok. Are you interested to open a new PR?

@ZhiyuanChen
Copy link
Copy Markdown
Contributor Author

ZhiyuanChen commented Oct 19, 2020

@ZhiyuanChen I think it is ok. Are you interested to open a new PR?

sure, it could take a few weeks since I'm actually quite busy these days

@ZhiyuanChen
Copy link
Copy Markdown
Contributor Author

ZhiyuanChen commented Oct 19, 2020

This file has many differences compared to the existing dasiamrpn.py, while they are actually very similar algorithm.
I think it would be better if we create a 'tracker' dir under https://github.com/opencv/opencv/blob/master/samples/dnn/ , and move both file inside, so that we could make them share a utils.py which generate anchors etc.

@ZhiyuanChen I think it is ok. Are you interested to open a new PR?

A WIP PR has been opened in #18627

@opencv-pushbot opencv-pushbot merged commit 9138c98 into opencv:3.4 Oct 19, 2020
@ZhiyuanChen ZhiyuanChen mentioned this pull request Oct 21, 2020
Closed
4 tasks
@alalek alalek mentioned this pull request Oct 21, 2020
Merged
@alalek alalek mentioned this pull request Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bhack bhack bhack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bhack bhack

Labels

category: samples category: tracking

Projects

None yet

Milestone

3.4.13

Development

Successfully merging this pull request may close these issues.

4 participants

@ZhiyuanChen @alalek @bhack @opencv-pushbot