Skip to content

Fix Objective-C/Swift binding's handling of properties with enum type #18605

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
komakai:fix-swift-binding
Oct 17, 2020
Merged

Fix Objective-C/Swift binding's handling of properties with enum type #18605
opencv-pushbot merged 1 commit intoopencv:masterfrom
komakai:fix-swift-binding

Conversation

@komakai
Copy link
Copy Markdown
Contributor

@komakai komakai commented Oct 17, 2020

Pull Request Readiness Checklist

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work

Fixes issue with Objective-C binding discovered while fixing #18598

  • when generating properties with enum type - add casts between the C++ enum and the Objective-C enum type
  • prevent the same header being included multiple times
  • minor code tidy-up

alalek
alalek approved these changes Oct 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 9c8626b into opencv:master Oct 17, 2020
@alalek alalek mentioned this pull request Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug category: swift/objc bindings platform: ios/osx

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@komakai @alalek @opencv-pushbot