G-API: Introduced a Text Detection sample#18476
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Oct 22, 2020
Merged
Conversation
Contributor
Author
|
@mpashchenkov fyi. Please apply for access to the OpenCV team to participate in reviews. |
Contributor
Author
|
Running example:
|
Contributor
Author
|
@alalek any chance to get this merged? |
Contributor
Author
|
Can promote it to the latest master to make sure |
alalek
reviewed
Oct 14, 2020
| auto lower = [](unsigned char c) { | ||
| return static_cast<unsigned char>(std::tolower(c)); | ||
| }; | ||
| std::transform(ext.begin(), ext.end(), ext.begin(), lower); |
| #include <opencv2/gapi/infer/ie.hpp> | ||
| #include <opencv2/gapi/streaming/cap.hpp> | ||
|
|
||
| #include <opencv2/highgui.hpp> // CommandLineParser |
Member
There was a problem hiding this comment.
?
CommandLineParser is from core/utility.hpp
| int main(int argc, char *argv[]) | ||
| { | ||
| try { | ||
| cv::CommandLineParser cmd(argc, argv, keys); |
Member
There was a problem hiding this comment.
You can avoid extra indentation from try block in this way:
static void run(int argc, char *argv[])
{
... code from try goes here ...
}
int main(int argc, char *argv[])
{
try
{
run(argc, argv);
}
catch ...
{
...
}
return 0;
}
Contributor
Author
There was a problem hiding this comment.
This try was only needed to debug Windows problems where exception text is not printed in console by default; so I removed it now.
alalek
reviewed
Oct 16, 2020
Comment on lines
1735
to
1759
| namespace streaming { | ||
| /** @brief Gets dimensions from Mat. | ||
|
|
||
| @note Function textual ID is "org.opencv.core.size" |
Member
There was a problem hiding this comment.
Do you really need namespace here?
namespace and ID doesn't look consistent.
Contributor
Author
There was a problem hiding this comment.
I will fix the IDs thanks.
03103a4 to
98f6291
Compare
This sample models the Text Detection demo from OMZ: https://github.com/openvinotoolkit/open_model_zoo/tree/2020.4/demos/text_detection_demo Also: renamed cv::gapi::size() to cv::gapi::streaming::size()
98f6291 to
95ff928
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sample models the Text Detection demo from OMZ:
https://github.com/openvinotoolkit/open_model_zoo/tree/2020.4/demos/text_detection_demo
Also: renamed cv::gapi::size() to cv::gapi::streaming::size()
Patch to opencv_extra has the same branch name.