ios: don't force BUILD_opencv_world=OFF in case of excluded modules#18449
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Sep 28, 2020
Merged
Conversation
Member
Author
|
👍 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates #7358 #18381
There is no reason to disable
opencv_worldin general. This special module includes subset of OpenCV modules. For example, it should be able to build withopencv_coreonly.Looks like disabling
opencv_worldwas wrong from the beginning (by #7358 and following fixes).P.S. Use
--without worldto disableopencv_worldagain/cc @komakai @sjang42 @nevir