Skip to content

calib3d: check for minimum corresponding points to calculate homography#18444

Merged
opencv-pushbot merged 2 commits intoopencv:3.4from
aitikgupta:check-minimum-points
Oct 2, 2020
Merged

calib3d: check for minimum corresponding points to calculate homography#18444
opencv-pushbot merged 2 commits intoopencv:3.4from
aitikgupta:check-minimum-points

Conversation

@aitikgupta
Copy link
Copy Markdown
Contributor

@aitikgupta aitikgupta commented Sep 27, 2020 •
edited by alalek
Loading

Fixes #18254

  • Added a check for minimum points to calculate Homography

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
allow_multiple_commits=1

alalek
alalek reviewed Sep 28, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

Please take a look on comment below.

@aitikgupta aitikgupta force-pushed the check-minimum-points branch 4 times, most recently from b22375d to 7224cff Compare September 28, 2020 13:01
@aitikgupta
Copy link
Copy Markdown
Contributor Author

aitikgupta commented Sep 28, 2020

@alalek Can you review again? Thanks

catree
catree reviewed Sep 28, 2020
View reviewed changes
@aitikgupta
Copy link
Copy Markdown
Contributor Author

aitikgupta commented Sep 28, 2020

@catree made the changes 👍

@aitikgupta
Copy link
Copy Markdown
Contributor Author

aitikgupta commented Sep 29, 2020

This 1 build timed out after 40 minutes. Not sure how to proceed?

alalek
alalek approved these changes Oct 2, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 3503a36 into opencv:3.4 Oct 2, 2020
@alalek alalek mentioned this pull request Oct 2, 2020
Merged
@aitikgupta aitikgupta deleted the check-minimum-points branch October 2, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

+1 more reviewer

@catree catree catree left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@alalek alalek

Labels

bug category: calib3d

Projects

None yet

Milestone

3.4.12

Development

Successfully merging this pull request may close these issues.

4 participants

@aitikgupta @alalek @catree @opencv-pushbot