Skip to content

dnn: improve debugging of ONNX parsing errors#18438

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:dnn_onnx_importer_error_reporting
Sep 29, 2020
Merged

dnn: improve debugging of ONNX parsing errors#18438
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:dnn_onnx_importer_error_reporting

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Sep 27, 2020

Emit more information from DNN ONNX importer.

Copy link
Copy Markdown
Member Author

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other changes don't affect importer results.

layerParams.set("bias_term", false);
node_proto.set_input(0, constParams.name);
node_proto.set_input(1, shapeIt->first);
node_proto.set_input(1, srcName);
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l-bat Please take a look on this change.
(shapeIt scope was too large, its locality is reduced to avoid errors and dangling pointers)

Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good for me!

Copy link
Copy Markdown
Contributor

@l-bat l-bat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you:+1:!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants