Skip to content

Fixed assertions on IPPE solver for SolvePnP#18378

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
nathanrgodwin:ippe_fix
Sep 23, 2020
Merged

Fixed assertions on IPPE solver for SolvePnP#18378
opencv-pushbot merged 1 commit intoopencv:3.4from
nathanrgodwin:ippe_fix

Conversation

@nathanrgodwin
Copy link
Copy Markdown
Contributor

This change fixes the argument checking assertions at the beginning of IPPE::PoseSolver::solveGeneric.

  • Changed number of point comparison to compare number of image points and number of object points.
  • Fixed typo in second CV_CheckType message
  • Fixed type checking for _objectPoints

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 9cfe981 into opencv:3.4 Sep 23, 2020
@alalek alalek mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants