Skip to content

Support global reduce ops#18299

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
l-bat:onnx_reduce_max
Sep 12, 2020
Merged

Support global reduce ops#18299
opencv-pushbot merged 1 commit intoopencv:3.4from
l-bat:onnx_reduce_max

Conversation

@l-bat
Copy link
Copy Markdown
Contributor

@l-bat l-bat commented Sep 9, 2020

merge with extra: opencv/opencv_extra#805

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2020.4.0:16.04
build_image:Custom Win=openvino-2020.3.0
build_image:Custom Mac=openvino-2020.3.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@l-bat l-bat added this to the 3.4.12 milestone Sep 9, 2020
@l-bat l-bat requested a review from dkurt September 9, 2020 11:16
dkurt
dkurt approved these changes Sep 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks! Does this PR resolve some issue?

@dkurt dkurt self-assigned this Sep 9, 2020
@l-bat
Copy link
Copy Markdown
Contributor Author

l-bat commented Sep 9, 2020

👍 Thanks! Does this PR resolve some issue?

This PR relates to #16783, but didn't resolve them

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Sep 10, 2020

/cc @sl-sergei

@sl-sergei
Copy link
Copy Markdown
Contributor

sl-sergei commented Sep 10, 2020

@l-bat The model from the issue also contains ReduceMin operation:

image

Do you plan to add it?

@l-bat
Copy link
Copy Markdown
Contributor Author

l-bat commented Sep 10, 2020

@l-bat The model from the issue also contains ReduceMin operation:

image

Do you plan to add it?

No, because ReduceMin is used for Constant, also we need to add a new Pooling mode for it or create a transformation subgraph, but this does not solve the issue.

@opencv-pushbot opencv-pushbot merged commit 8380781 into opencv:3.4 Sep 12, 2020
@alalek alalek mentioned this pull request Sep 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn feature

Projects

None yet

Milestone

3.4.12

Development

Successfully merging this pull request may close these issues.

5 participants

@l-bat @asmorkalov @sl-sergei @dkurt @opencv-pushbot