Install: added prebuilt samples installation#18294
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Sep 15, 2020
Merged
Conversation
alalek
approved these changes
Sep 14, 2020
| if(WIN32) | ||
| install(TARGETS ${the_target} RUNTIME DESTINATION "samples/${module_id}" COMPONENT samples) | ||
| if(INSTALL_BIN_EXAMPLES) | ||
| install(TARGETS ${the_target} RUNTIME DESTINATION "${OPENCV_SAMPLES_BIN_INSTALL_PATH}/${module_id}" COMPONENT samples) |
Member
There was a problem hiding this comment.
Please put default value into "OpenCVInstallLayout.cmake" too.
Contributor
Author
There was a problem hiding this comment.
Do you mean for OPENCV_SAMPLES_BIN_INSTALL_PATH? It is already there, e.g. Unix
opencv/cmake/OpenCVInstallLayout.cmake
Line 64 in 3b00ee2
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When option
INSTALL_BIN_EXAMPLESis enabled, prebuilt samples binaries will be installed to theOPENCV_SAMPLES_BIN_INSTALL_PATHlocation. This variable was set but not used.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.