Skip to content

dnn(permute): do not allocate UMat in non-OpenCL targets#18246

Merged
opencv-pushbot merged 2 commits intoopencv:3.4from
YashasSamaga:dnn-permute-fix-unwanted-ocl-init
Sep 2, 2020
Merged

dnn(permute): do not allocate UMat in non-OpenCL targets#18246
opencv-pushbot merged 2 commits intoopencv:3.4from
YashasSamaga:dnn-permute-fix-unwanted-ocl-init

Conversation

@YashasSamaga
Copy link
Copy Markdown
Contributor

@YashasSamaga YashasSamaga commented Sep 2, 2020

UMat allocation in CUDA targets causes unused CUDA devices (as OpenCL devices) to be initialized by these unexpected allocations in OpenCV 4. This PR stops these unwanted allocations from taking place if they are not required.

resolves #17852

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
allow_multiple_commits=1

force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2020.4.0:16.04
build_image:Custom Win=openvino-2020.3.0
build_image:Custom Mac=openvino-2020.3.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@YashasSamaga YashasSamaga force-pushed the dnn-permute-fix-unwanted-ocl-init branch from f4b33ce to 44bf748 Compare September 2, 2020 06:49
@YashasSamaga YashasSamaga marked this pull request as ready for review September 2, 2020 13:43
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@opencv-pushbot opencv-pushbot merged commit 64c67a9 into opencv:3.4 Sep 2, 2020
@alalek alalek mentioned this pull request Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants