[3.4] Fix cubic root computation in calibrateHandEye#18165
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Aug 25, 2020
Merged
[3.4] Fix cubic root computation in calibrateHandEye#18165opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
catree
commented
Aug 21, 2020
f704c14 to
2dcb5be
Compare
alalek
reviewed
Aug 23, 2020
| //Eq 15 | ||
| double det = determinant(R); | ||
| R = pow(sign_double(det) / abs(det), 1.0/3.0) * R; | ||
| R = cubic_root(sign_double(det) / abs(det)) * R; |
Member
There was a problem hiding this comment.
What is wrong with cv:cubeRoot()?
Contributor
Author
There was a problem hiding this comment.
What is wrong with cv:cubeRoot()`?
Didn't know of this function.
For master, I still think it is better and cleaner to use C+11 std::cbrt since cubeRoot is only single-precision accuracy.
Feel free to close the master PR if it is easier to merge 3.4 in master.
The code does this:
37f2bcc to
062ec7e
Compare
…ove doc. Add regression test.
062ec7e to
379b83e
Compare
alalek
approved these changes
Aug 25, 2020
Member
alalek
left a comment
There was a problem hiding this comment.
Well done! Thank you for contribution 👍
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with extra: opencv/opencv_extra#800
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Specific fix for 3.4 branch since I don't want to have ugly code to test for C++11 features in master just because 3.4 branch is tied to obsolete < C++11 version.