Merged
Conversation
c3a64d3 to
382a87c
Compare
mshabunin
reviewed
Aug 19, 2020
022414f to
5dd857a
Compare
asmorkalov
requested changes
Aug 20, 2020
samples/cpp/stereo_match.cpp
Outdated
| } | ||
|
|
||
| if(!disparity_filename.empty()) | ||
| imwrite(disparity_filename, disp8); |
Contributor
There was a problem hiding this comment.
--color option handling is missed here.
mshabunin
approved these changes
Aug 20, 2020
Contributor
Author
|
It's on purpose.
Datasets are giving ground truth on one channel (8 or more bits that can be
converted to 8 bits). Storing the image on one channel also allows direct
comparison with these ground truths, knowing in addition that the choice of
the color map might not be the same one from one dataset to another one
when used for display.
If we want to store color mapped disparity images for visual comparison,
screenshot is an option as it keeps track in the title bar of the different
settings used for the process.
Are you fine with that?
Le jeu. 20 août 2020 à 09:43, Alexander Smorkalov <notifications@github.com>
a écrit :
… ***@***.**** requested changes on this pull request.
------------------------------
In samples/cpp/stereo_match.cpp
<#18129 (comment)>:
> @@ -268,19 +274,6 @@ int main(int argc, char** argv)
disp.convertTo(disp8, CV_8U, 255/(numberOfDisparities*16.));
else
disp.convertTo(disp8, CV_8U);
- if( !no_display )
- {
- namedWindow("left", 1);
- imshow("left", img1);
- namedWindow("right", 1);
- imshow("right", img2);
- namedWindow("disparity", 0);
- imshow("disparity", disp8);
- printf("press any key to continue...");
- fflush(stdout);
- waitKey();
- printf("\n");
- }
if(!disparity_filename.empty())
imwrite(disparity_filename, disp8);
--color option handling is missed here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18129 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPELVIX756VKRDQDE4PCX3SBTH2PANCNFSM4QDRHNBA>
.
|
Contributor
|
The default behavior is to produce one channel disparity image. It works with datasets as you expect. I just propose to have the consistent option behavior for case with window and in "no-display" mode. It can be used for testing. |
* add the HH4 mode * option to display disparity with a color map * display current settings in the title bar * don't close app when wanting to take screenshots
5dd857a to
6d1f7c2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.