Account for sample weights in calculating OOB Error#18126
Merged
alalek merged 3 commits intoopencv:3.4from Sep 5, 2020
Merged
Conversation
2ac6d3e to
297efd3
Compare
Member
|
/cc @vpisarev Please take a look on "open questions". |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #11142, this PR adds logic to account for sample weights when computing the oobError during training in rtrees.
Open questions:
oobErrorbe moved outside the loop to ensure it's computed for the forest, rather than being reset per tree? That would also require changing the termination condition (maybe using a local error accumulator which as added tooobError).n_oob?This also addresses #4431, as it makes OOB error accessible.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.