Skip to content

highgui: don't terminate if we can't initialize GTK backend#18105

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:highgui_gtk_dont_terminate
Aug 17, 2020
Merged

highgui: don't terminate if we can't initialize GTK backend#18105
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:highgui_gtk_dont_terminate

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Aug 16, 2020

  • allow Users to handle such case
  • exception will be thrown instead

Useful for docker containers or other environments without configured DISPLAY.

GTK doc reference:


Before:

  • terminate() called with message "Gtk-WARNING **: 09:37:26.975: cannot open display:"

After:

  • throws C++ exception from imshow() and subsequent calls.

- allow Users to handle such case
- exception will be thrown instead
@asmorkalov asmorkalov self-requested a review August 17, 2020 07:35
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Do you plan to do it for QT backend too?

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Do you plan to do it for QT backend too?

@opencv-pushbot opencv-pushbot merged commit b34234a into opencv:3.4 Aug 17, 2020
@alalek alalek mentioned this pull request Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants