Skip to content

Supported ReduceSum op#18077

Merged
alalek merged 2 commits intoopencv:3.4from
l-bat:reduce_sum
Aug 12, 2020
Merged

Supported ReduceSum op#18077
alalek merged 2 commits intoopencv:3.4from
l-bat:reduce_sum

Conversation

@l-bat
Copy link
Copy Markdown
Contributor

@l-bat l-bat commented Aug 12, 2020 •
edited by alalek
Loading

relates: #14312
merge with extra: opencv/opencv_extra#787

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2020.4.0:16.04
build_image:Custom Win=openvino-2020.4.0
build_image:Custom Mac=openvino-2020.3.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

dkurt
dkurt reviewed Aug 12, 2020
View reviewed changes
@dkurt dkurt linked an issue Aug 12, 2020 that may be closed by this pull request
Can't create layer of type "Sum" in function 'getLayerInstance' #14312
Closed
@dkurt
Copy link
Copy Markdown
Member

dkurt commented Aug 12, 2020 •
edited
Loading

please take a look at failed tests: https://pullrequest.opencv.org/buildbot/builders/precommit_custom_linux/builds/4234 (please add skip for DLIE/MYRIAD)

dkurt
dkurt approved these changes Aug 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Well done!

@dkurt dkurt self-assigned this Aug 12, 2020
@alalek alalek merged commit f3cebb3 into opencv:3.4 Aug 12, 2020
@dkurt dkurt mentioned this pull request Aug 12, 2020
Closed
@alalek alalek mentioned this pull request Aug 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn feature test

Projects

None yet

Milestone

3.4.12

Development

Successfully merging this pull request may close these issues.

Can't create layer of type "Sum" in function 'getLayerInstance'

3 participants

@l-bat @dkurt @alalek