Skip to content

Removed get_output_as_single_output_node method#18031

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
ilyachur:feature/ichuraev/remove_goe
Aug 10, 2020
Merged

Removed get_output_as_single_output_node method#18031
opencv-pushbot merged 1 commit intoopencv:masterfrom
ilyachur:feature/ichuraev/remove_goe

Conversation

@ilyachur
Copy link
Copy Markdown
Contributor

@ilyachur ilyachur commented Aug 4, 2020 •
edited by alalek
Loading

This PR is needed for openvinotoolkit/openvino#1604

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2020.4.0:16.04
build_image:Custom Win=openvino-2020.3.0
build_image:Custom Mac=openvino-2020.2.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

dkurt
dkurt reviewed Aug 4, 2020
View reviewed changes
modules/dnn/src/dnn.cpp
CV_Assert(oid < ieInpNode->node->get_output_size());
#if INF_ENGINE_VER_MAJOR_GT(INF_ENGINE_RELEASE_2020_3)
#if INF_ENGINE_VER_MAJOR_GT(INF_ENGINE_RELEASE_2020_4)
inputNodes[i] = Ptr<BackendNode>(new InfEngineNgraphNode(ieInpNode->node));
Copy link
Copy Markdown
Member

@dkurt dkurt Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this method does not depend on output id (oid)

Copy link
Copy Markdown
Contributor Author

@ilyachur ilyachur Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, at the current moment this method uses node from ieImplNode.
But it can be incorrect if this node has several outputs. In this case it is better to use Output<Node> instead of std::shared_prt<Node>

@ilyachur ilyachur marked this pull request as ready for review August 10, 2020 04:01
@mshabunin mshabunin self-assigned this Aug 10, 2020
@opencv-pushbot opencv-pushbot merged commit 2ffe15f into opencv:master Aug 10, 2020
@alalek alalek mentioned this pull request Oct 5, 2020
Merged
@alalek alalek mentioned this pull request Feb 5, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt left review comments

@mshabunin mshabunin mshabunin approved these changes

Assignees

@mshabunin mshabunin

Labels

category: dnn port/backport done Label for maintainers. Authors of PR can ignore this

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ilyachur @mshabunin @dkurt @opencv-pushbot @asmorkalov @alalek