Skip to content

Document PatchNANs input type (issue #18000)#18008

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
gsmatos:document-patchnans
Aug 4, 2020
Merged

Document PatchNANs input type (issue #18000)#18008
opencv-pushbot merged 1 commit intoopencv:3.4from
gsmatos:document-patchnans

Conversation

@gsmatos
Copy link
Copy Markdown
Contributor

@gsmatos gsmatos commented Aug 1, 2020 •
edited by asmorkalov
Loading

Fixes #18000

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@gsmatos gsmatos changed the title Document PatchNANs input type Document PatchNANs input type (issue #18000) Aug 1, 2020
@asmorkalov asmorkalov added the category: documentation Documentation fix or update label Aug 3, 2020
@asmorkalov asmorkalov self-requested a review August 3, 2020 09:20
asmorkalov
asmorkalov requested changes Aug 3, 2020
View reviewed changes
modules/core/include/opencv2/core.hpp Outdated
double minVal = -DBL_MAX, double maxVal = DBL_MAX);

/** @brief converts NaN's to the given number
@param a input/output matrix (CV_32FC1 type).
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to replace CV_32FC1 with CV_32F, amount of channels does not matter.

Copy link
Copy Markdown
Contributor Author

@gsmatos gsmatos Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fixed

@asmorkalov asmorkalov added the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Aug 3, 2020
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Aug 3, 2020

Thanks for the contribution. This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no need to re-open PR, apply changes "inplace".

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Aug 3, 2020

Doxygen documentation with CI bot reports new warnings. You need to document all function parameters to fix the CI warning.

@gsmatos gsmatos changed the base branch from master to 3.4 August 4, 2020 01:40
@gsmatos gsmatos force-pushed the document-patchnans branch from 07cbe43 to 3744b3f Compare August 4, 2020 01:42
@gsmatos gsmatos force-pushed the document-patchnans branch from 3744b3f to 96ce65f Compare August 4, 2020 01:57
@asmorkalov asmorkalov self-requested a review August 4, 2020 06:55
asmorkalov
asmorkalov approved these changes Aug 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

asmorkalov
asmorkalov approved these changes Aug 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@asmorkalov asmorkalov removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Aug 4, 2020
@asmorkalov asmorkalov self-assigned this Aug 4, 2020
@opencv-pushbot opencv-pushbot merged commit 35846fe into opencv:3.4 Aug 4, 2020
@alalek alalek mentioned this pull request Aug 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.12

Development

Successfully merging this pull request may close these issues.

The documentation doesn't specify the input type of patchNaNs

4 participants

@gsmatos @asmorkalov @opencv-pushbot @alalek