Skip to content

Replace nGraph's i64 to i32 for size_t#17998

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
dkurt:dnn_fix_ngraph
Aug 3, 2020
Merged

Replace nGraph's i64 to i32 for size_t#17998
opencv-pushbot merged 1 commit intoopencv:3.4from
dkurt:dnn_fix_ngraph

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented Jul 30, 2020 •
edited
Loading

resolves openvinotoolkit/openvino#1503
resolves #17954

Merge with extra: opencv/opencv_extra#779

force_builders=Custom,Custom Win,Custom Mac
#build_image:Custom=ubuntu-openvino-2020.1.0:16.04
build_image:Custom=ubuntu-openvino-2020.2.0:16.04
build_image:Custom Win=openvino-2020.3.0
build_image:Custom Mac=openvino-2020.2.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

This was referenced Jul 30, 2020
Closed
Closed
@dkurt dkurt linked an issue Jul 30, 2020 that may be closed by this pull request
Crash in net.forward() using inference engine on Raspberry Pi 4 and Intel NCS2 #17954
Closed
@dkurt dkurt force-pushed the dnn_fix_ngraph branch 2 times, most recently from 0221bbf to 86b17d4 Compare July 30, 2020 22:12
@asmorkalov asmorkalov changed the title Replace nGraph's i63 to i32 for size_t Replace nGraph's i64 to i32 for size_t Jul 31, 2020
@asmorkalov asmorkalov requested a review from alalek July 31, 2020 10:50
@alalek
Copy link
Copy Markdown
Member

alalek commented Aug 2, 2020

@dkurt Please take a look on issues with older OV packages (at least we should support 2020.3 LTS somehow)

@dkurt
Copy link
Copy Markdown
Member Author

dkurt commented Aug 2, 2020

@alelek, I will try to replace all of them to int64_t this way. Main goal is to remove size_t which turn to 32bit or 64bit depends on OS bitness.

@dkurt dkurt force-pushed the dnn_fix_ngraph branch 3 times, most recently from 44595bc to 4db9fa6 Compare August 2, 2020 16:10
@dkurt
Copy link
Copy Markdown
Member Author

dkurt commented Aug 2, 2020

There are only 2 failed tests on ubuntu-openvino-2020.1.0:16.04:

[  FAILED  ] Layer_Test_Slice.slice_channels_and_batch_17762/3, where GetParam() = NGRAPH/MYRIAD
[  FAILED  ] Test_ONNX_layers.Gather/3, where GetParam() = NGRAPH/MYRIAD

l-bat
l-bat approved these changes Aug 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@l-bat l-bat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@opencv-pushbot opencv-pushbot merged commit a285339 into opencv:3.4 Aug 3, 2020
@avitial avitial mentioned this pull request Aug 5, 2020
Closed
@alalek alalek mentioned this pull request Aug 5, 2020
Merged
@alvoron alvoron mentioned this pull request Apr 21, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l-bat l-bat l-bat approved these changes

Assignees

@l-bat l-bat

Labels

category: dnn

Projects

None yet

Milestone

3.4.12

Development

Successfully merging this pull request may close these issues.

Crash in net.forward() using inference engine on Raspberry Pi 4 and Intel NCS2

4 participants

@dkurt @alalek @l-bat @opencv-pushbot