Skip to content

[IE][VPU]: Refactor vpu configs#17993

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
Maxim-Doronin:vpu/mdoronin/refactor_vpu_configs
Aug 17, 2020
Merged

[IE][VPU]: Refactor vpu configs#17993
opencv-pushbot merged 1 commit intoopencv:masterfrom
Maxim-Doronin:vpu/mdoronin/refactor_vpu_configs

Conversation

@Maxim-Doronin
Copy link
Copy Markdown
Contributor

@Maxim-Doronin Maxim-Doronin commented Jul 30, 2020

related PR in openvino
openvinotoolkit/openvino#1334

MUST BE merged after merging related PR's

@Maxim-Doronin Maxim-Doronin force-pushed the vpu/mdoronin/refactor_vpu_configs branch from 6cc8b69 to 2033ab3 Compare July 31, 2020 09:07
@Maxim-Doronin Maxim-Doronin marked this pull request as ready for review July 31, 2020 16:09
@alalek
Copy link
Copy Markdown
Member

alalek commented Aug 2, 2020

Please take a look on discussion about API breaking changes and merging process: #17888

@Maxim-Doronin Maxim-Doronin force-pushed the vpu/mdoronin/refactor_vpu_configs branch from 2033ab3 to 2a98fd7 Compare August 3, 2020 12:10
@dkurt
Copy link
Copy Markdown
Member

dkurt commented Aug 3, 2020

If I'm not mistaken, there should be a macros for it, VPU_CONFIG_KEY. May we ask to change to

#include <vpu/vpu_plugin_config.hpp>
//...
config.emplace(VPU_CONFIG_KEY("DETECT_NETWORK_BATCH"), CONFIG_VALUE(NO));

?

@Maxim-Doronin
Copy link
Copy Markdown
Contributor Author

If I'm not mistaken, there should be a macros for it, VPU_CONFIG_KEY. May we ask to change to

#include <vpu/vpu_plugin_config.hpp>
//...
config.emplace(VPU_CONFIG_KEY("DETECT_NETWORK_BATCH"), CONFIG_VALUE(NO));

?

DETECT_NETWORK_BATCH is a private plugin config. To use it as a variable, not as a string, we should include myriad plugin targets explicitly

@Maxim-Doronin Maxim-Doronin force-pushed the vpu/mdoronin/refactor_vpu_configs branch from 2a98fd7 to 7fe87d9 Compare August 13, 2020 12:25
@Maxim-Doronin
Copy link
Copy Markdown
Contributor Author

@dkurt, the main PR openvinotoolkit/openvino#1334 was merged. Could you take a look once again?

Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Let's merge. Thanks!

@dkurt dkurt added the backport is needed Label for maintainers. Authors of PR can ignore this label Aug 17, 2020
@dkurt dkurt self-assigned this Aug 17, 2020
@opencv-pushbot opencv-pushbot merged commit 41548a0 into opencv:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: dnn port/backport done Label for maintainers. Authors of PR can ignore this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants