Skip to content

Fix Carotene compilation with XCode#17987

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
mshabunin:fix-xcode-carotene
Jul 31, 2020
Merged

Fix Carotene compilation with XCode#17987
opencv-pushbot merged 1 commit intoopencv:3.4from
mshabunin:fix-xcode-carotene

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

When building with XCode for ARM, carotene and tegra_hal static libraries will be deleted. Probably caused by issue: https://gitlab.kitware.com/cmake/cmake/-/issues/17457

From cmake docs:

Some native build systems may not like targets that have only object files, so consider adding at least one real source file

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

@mshabunin I propose to add comment line to the dummy.cpp with reference to CMake bug.

@asmorkalov asmorkalov self-requested a review July 30, 2020 09:47
@asmorkalov asmorkalov added platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc platform: ios/osx labels Jul 30, 2020
@mshabunin mshabunin force-pushed the fix-xcode-carotene branch from 09050de to 866468c Compare July 30, 2020 19:53
@opencv-pushbot opencv-pushbot merged commit f162c08 into opencv:3.4 Jul 31, 2020
@alalek alalek mentioned this pull request Aug 5, 2020
@mshabunin mshabunin deleted the fix-xcode-carotene branch July 10, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: build/install platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc platform: ios/osx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants