Skip to content

Update samples#17928

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
sturkmen72:update_samples
Jul 27, 2020
Merged

Update samples#17928
opencv-pushbot merged 1 commit intoopencv:3.4from
sturkmen72:update_samples

Conversation

@sturkmen72
Copy link
Copy Markdown
Contributor

@sturkmen72 sturkmen72 commented Jul 23, 2020

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from mshabunin July 24, 2020 08:26
@asmorkalov asmorkalov self-requested a review July 27, 2020 08:18
asmorkalov
asmorkalov approved these changes Jul 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested manually with Ubuntu 18.04.

@opencv-pushbot opencv-pushbot merged commit e935f06 into opencv:3.4 Jul 27, 2020
@mshabunin mshabunin added the port into 4.x is needed Label for maintainers. Authors of PR can ignore this label Jul 27, 2020
@sturkmen72 sturkmen72 deleted the update_samples branch July 27, 2020 11:46
@alalek alalek mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@mshabunin mshabunin Awaiting requested review from mshabunin

Assignees

@asmorkalov asmorkalov

Labels

category: samples

Projects

None yet

Milestone

3.4.12

Development

Successfully merging this pull request may close these issues.

5 participants

@sturkmen72 @asmorkalov @opencv-pushbot @mshabunin @alalek