Skip to content

Fixed checkMasks in DescriptorMatcher with train descs in UMats#17772

Merged
opencv-pushbot merged 2 commits intoopencv:3.4from
mshabunin:fix-match-umat-mask
Jul 10, 2020
Merged

Fixed checkMasks in DescriptorMatcher with train descs in UMats#17772
opencv-pushbot merged 2 commits intoopencv:3.4from
mshabunin:fix-match-umat-mask

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin commented Jul 7, 2020 •
edited by alalek
Loading

resolves #17771

Applied patch from the issue + minor refactoring and formatting

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
allow_multiple_commits=1

@alalek
Copy link
Copy Markdown
Member

alalek commented Jul 8, 2020

@mshabunin Is it possible to add some simple test for that?

@mshabunin mshabunin force-pushed the fix-match-umat-mask branch from e53aad1 to 938af84 Compare July 9, 2020 13:05
@mshabunin mshabunin force-pushed the fix-match-umat-mask branch from 938af84 to 4dd9a36 Compare July 9, 2020 13:22
@mshabunin
Copy link
Copy Markdown
Contributor Author

mshabunin commented Jul 9, 2020

@alalek , I've added the test reproducing the original issue.

alalek
alalek approved these changes Jul 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@opencv-pushbot opencv-pushbot merged commit d2469ed into opencv:3.4 Jul 10, 2020
@alalek alalek mentioned this pull request Jul 13, 2020
Merged
@mshabunin mshabunin deleted the fix-match-umat-mask branch July 14, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug category: features2d

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

Failed to match UMat descriptors

3 participants

@mshabunin @alalek @opencv-pushbot