Skip to content

dnn: fix OpenCL implementation of Slice layer#17764

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:issue_17762
Jul 16, 2020
Merged

dnn: fix OpenCL implementation of Slice layer#17764
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:issue_17762

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Jul 6, 2020 •
edited
Loading

resolves #17762
relates #17743

TODO:

  • performance test
  • optimizations w/o regressions
  • drop debug code
**WIP**
test_modules=dnn

Xbuild_image:Custom=ubuntu:18.04
Xbuildworker:Custom=linux-5
Xtest_opencl:Custom=ON

build_image:Linux AVX2=ubuntu:18.04
buildworker:Linux AVX2=linux-3
test_opencl:Linux AVX2=ON

build_image:Custom=ubuntu-openvino-2020.3.0:16.04
build_image:Custom Win=openvino-2020.3.0
Xbuild_image:Custom Win=openvino-2019r3.0
build_image:Custom Mac=openvino-2020.3.0

Xtest_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*lice*:*plit*

test_opencl:Custom Win=ON
test_bigdata:Custom Win=1
test_filter:Custom Win=*lice*:*plit*

dkurt
dkurt reviewed Jul 7, 2020
View reviewed changes
modules/dnn/src/layers/slice_layer.cpp Outdated
{
UMat& output = outputs[i];
#if 0 // TODO: core - support non-contiguous ND layouts
input(finalSliceRanges[i]).copyTo(output);
Copy link
Copy Markdown
Member

@dkurt dkurt Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems strange why input is not contiguous.

Copy link
Copy Markdown
Member Author

@alalek alalek Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Input is contiguous, but ROI/slice is not.

@alalek
Copy link
Copy Markdown
Member Author

alalek commented Jul 16, 2020

👍

@opencv-pushbot opencv-pushbot merged commit 09f24a8 into opencv:3.4 Jul 16, 2020
This was referenced Jul 16, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt left review comments

Assignees

@alalek alalek

Labels

bug category: dnn category: ocl

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

DNN: YOLOv4-tiny no detections for OpenCV/OpenCL target

3 participants

@alalek @dkurt @opencv-pushbot