Skip to content

dnn: allow concat fusion for non-channel axis#17752

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
YashasSamaga:generalize-concat-fusion-3.4
Jul 7, 2020
Merged

dnn: allow concat fusion for non-channel axis#17752
opencv-pushbot merged 1 commit intoopencv:3.4from
YashasSamaga:generalize-concat-fusion-3.4

Conversation

@YashasSamaga
Copy link
Copy Markdown
Contributor

@YashasSamaga YashasSamaga commented Jul 4, 2020

  • clamps concat axis before use (otherwise valid fusions where axis is negative won't happen)
  • generalizes the axis requirement from channels to any axis as long as all channels preceding the concat axis are singleton

I haven't fixed the comments. Not sure how to rewrite them.

For the list of models you find here:
number of concat fusions before: 60
number of concat fusions after: 72

List of fusions before and after: https://gist.github.com/YashasSamaga/94449832c25f2993cfc8ffc0a8bdf618

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants