Skip to content

Adding comment from source code to DetectionOutputLayer class documentation#17742

Merged
alalek merged 3 commits intoopencv:3.4from
SoheibKadi:DetectionOutput_layer_doc
Aug 3, 2020
Merged

Adding comment from source code to DetectionOutputLayer class documentation#17742
alalek merged 3 commits intoopencv:3.4from
SoheibKadi:DetectionOutput_layer_doc

Conversation

@SoheibKadi
Copy link
Copy Markdown
Contributor

@SoheibKadi SoheibKadi commented Jul 3, 2020 •
edited by alalek
Loading

Adds a comment written in the source code for bool getMemoryShapes into the DetectionOutputLayer class documentation, as requested in this issue:

resolves #14645

force_builders_only=Docs

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 3, 2020 •
edited
Loading

please do not duplicate issue but help to resolve it.

Oh sorry. Just thought it's an issue :) Thanks for contribution!

dkurt
dkurt reviewed Jul 3, 2020
View reviewed changes
dkurt
dkurt reviewed Jul 3, 2020
View reviewed changes
@alalek
Copy link
Copy Markdown
Member

alalek commented Jul 3, 2020

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@SoheibKadi SoheibKadi changed the base branch from master to 3.4 July 4, 2020 03:16
@SoheibKadi SoheibKadi force-pushed the DetectionOutput_layer_doc branch from a011eb3 to 17c430d Compare July 4, 2020 03:41
@SoheibKadi SoheibKadi requested a review from dkurt July 5, 2020 18:20
dkurt
dkurt reviewed Jul 6, 2020
View reviewed changes
@dkurt dkurt removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Jul 7, 2020
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 27, 2020

@SoheibKadi friendly reminder.

dkurt
dkurt approved these changes Jul 31, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alalek alalek merged commit 65b02cc into opencv:3.4 Aug 3, 2020
@alalek alalek mentioned this pull request Aug 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.12

Development

Successfully merging this pull request may close these issues.

4 participants

@SoheibKadi @dkurt @alalek @asmorkalov