Skip to content

Fix trees parsing behavior in hierarchical_clustering_index:#17737

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
pemmanuelviel:pev--fix-trees-descent
Jul 8, 2020
Merged

Fix trees parsing behavior in hierarchical_clustering_index:#17737
opencv-pushbot merged 1 commit intoopencv:3.4from
pemmanuelviel:pev--fix-trees-descent

Conversation

@pemmanuelviel
Copy link
Copy Markdown
Contributor

@pemmanuelviel pemmanuelviel commented Jul 2, 2020 •
edited
Loading

Before, when maxCheck was reached in the first descent of a tree, time was still wasted parsing
the next trees till their best leaves whose points were not used at all.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@pemmanuelviel
Fix trees parsing behavior in hierarchical_clustering_index:
7286848 
Before, when maxCheck was reached in the first descent of a tree, time was still wasted parsing
the next trees till their best leaves whose points were not used at all.
@pemmanuelviel
Copy link
Copy Markdown
Contributor Author

pemmanuelviel commented Jul 2, 2020

Unlike the similar PR on master, this one doesn't offer the choice to the user with an extra parameter between improved speed or accuracy. This is only speed here.

alalek
alalek approved these changes Jul 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 5bc6b6f into opencv:3.4 Jul 8, 2020
@alalek alalek mentioned this pull request Jul 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug category: flann

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

3 participants

@pemmanuelviel @alalek @opencv-pushbot