Skip to content

Mix of 32 and 64bits vector types prevents vectorisation for distance…#17724

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
pemmanuelviel:pev--fix-mix-of-types
Jul 4, 2020
Merged

Mix of 32 and 64bits vector types prevents vectorisation for distance…#17724
opencv-pushbot merged 1 commit intoopencv:3.4from
pemmanuelviel:pev--fix-mix-of-types

Conversation

@pemmanuelviel
Copy link
Copy Markdown
Contributor

@pemmanuelviel pemmanuelviel commented Jul 1, 2020

… computation.

Argument "a" is of type ElementType* that is either int* or float*, while b was double*.
Mixing types prevents the possibility to use SSE or AVX instructions.
On implementation without SIMD instructions, this doesn't show any impact on performance.

test_module_force=flann

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

… computation.

Argument "a" is of type ElementType* that is either int* or float*, while b was double*.
Mixing types prevents the possibility to use SSE or AVX instructions.
On implementation without SIMD instructions, this doesn't show any impact on performance.
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution 👍

@opencv-pushbot opencv-pushbot merged commit deaf1dd into opencv:3.4 Jul 4, 2020
@pemmanuelviel pemmanuelviel deleted the pev--fix-mix-of-types branch July 5, 2020 11:39
@alalek alalek mentioned this pull request Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants