ximgproc: add loose comparison based on pixel count#17691
ximgproc: add loose comparison based on pixel count#17691tomoaki0705 wants to merge 1 commit intoopencv:3.4from
Conversation
| void compare(const Mat& src, double s, Mat& dst, int cmpop); | ||
|
|
||
| int countExceed(const Mat& src, double value, int cmpop); | ||
| int countExceed(const Mat& src1, const Mat& src2, double value, int cmpop); |
There was a problem hiding this comment.
Functions around the added stuff are reference implementations to test optimizations of OpenCV basic functionality. They do not perform any "checks".
"Check" functions should be created as GoogleTest reporters (with "void" result value).
Also you can see take a look on macros with EXPECT_ prefix from ts/include.
There was a problem hiding this comment.
Functions around the added stuff are reference implementations to test optimizations of OpenCV basic functionality. They do not perform any "checks".
Right they don't perform any checks, but this function only "counts" and doesn't "checks".
I expect the check to be done by EXPECT_LE like here
I'm not sure if we are on the same page.
Yes, may be the title of this PR was misleading. If so, I can update the title.
If I'm not understanding your opinion correctly, could you guide me to any implementations I should follow, please ?
There was a problem hiding this comment.
This is wrong place for check helper functions.
There are reference implementations to test optimizations of OpenCV basic functionality.
Lets do not mess them.
I should follow
I will add more constructive comment later. Proper infrastructure decision is required here.
There was a problem hiding this comment.
@tomoaki0705 There is no architecture decision yet. Could you please move code of this implementation into related opencv_contrib PR to merge it and to unblock testing?
There was a problem hiding this comment.
I pushed so opencv/opencv_contrib#2581 should be able to build/pass without this PR
realtes opencv/opencv_contrib#2581
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.