Skip to content

Pev fix bad any cast in lsh#17684

Closed
pemmanuelviel wants to merge 2 commits intoopencv:3.4from
pemmanuelviel:pev--fix-bad-any-cast-in-lsh
Closed

Pev fix bad any cast in lsh#17684
pemmanuelviel wants to merge 2 commits intoopencv:3.4from
pemmanuelviel:pev--fix-bad-any-cast-in-lsh

Conversation

@pemmanuelviel
Copy link
Copy Markdown
Contributor

@pemmanuelviel pemmanuelviel commented Jun 28, 2020 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@pemmanuelviel
Copy link
Copy Markdown
Contributor Author

pemmanuelviel commented Jun 28, 2020

Branch replacing pev--fix-lsh-bad-any-cast.
Here we don't change any unsigned int for int type for table_number_, key_size_ and multi_probe_level_.
However, as

  • in all the others types of IndexParams the types are int an not unsigned int
  • and the version of these three parameters in LshIndexParams of miniflann is int and not unsigned int,
    I would recommend to switch to int in master branch, what is actually doing the "pev-fix-lsh-bad-any-cast" (one dash and not two after pev to easily identify between master based branched and 3.4 based ones)

@pemmanuelviel pemmanuelviel force-pushed the pev--fix-bad-any-cast-in-lsh branch from 8dc6542 to c1e663e Compare June 28, 2020 15:12
@alalek
Copy link
Copy Markdown
Member

alalek commented Jun 28, 2020

I pushed your test code and preserve "int" fields to previous PR #17640 . Please take a look.
Also I reconfigured ABI checker to avoid false-positives.

BTW, no need to re-open PR - just force-push changes on existed branches.
Lets close this and use #17640.

@alalek alalek mentioned this pull request Jun 29, 2020
Closed
6 tasks
@pemmanuelviel pemmanuelviel deleted the pev--fix-bad-any-cast-in-lsh branch July 2, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pemmanuelviel @alalek