Skip to content

Fix: error in the dimension used for computeMinMax#17641

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
pemmanuelviel:pev--fix-middleSplit-for-kdtree-single
Jun 25, 2020
Merged

Fix: error in the dimension used for computeMinMax#17641
opencv-pushbot merged 1 commit intoopencv:3.4from
pemmanuelviel:pev--fix-middleSplit-for-kdtree-single

Conversation

@pemmanuelviel
Copy link
Copy Markdown
Contributor

@pemmanuelviel pemmanuelviel commented Jun 23, 2020

Instead of using the current dimension for which we just got a big span,
we were computing Min and Max for the previous dimension stored in cutfeat
(and using 0 instead of the dimension indice for the very first dimension
with "span > (1-eps)max_span")

closes #17607

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Instead of using the current dimension for which we just got a big span,
we were computing Min and Max for the previous dimension stored in cutfeat
(and using 0 instead of the dimension indice for the very first dimension
with "span > (1-eps)max_span")
@vpisarev vpisarev self-assigned this Jun 25, 2020
@vpisarev
Copy link
Copy Markdown
Contributor

thank you for the contribution! 👍

@opencv-pushbot opencv-pushbot merged commit 6259ba1 into opencv:3.4 Jun 25, 2020
@alalek alalek mentioned this pull request Jun 29, 2020
@pemmanuelviel pemmanuelviel deleted the pev--fix-middleSplit-for-kdtree-single branch July 2, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants