support indexed color images on iOS#17636
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jun 27, 2020
Merged
Conversation
Member
komakai
reviewed
Jun 25, 2020
Contributor
komakai
left a comment
There was a problem hiding this comment.
@okamotoR looks basically good - a few questions:
- can you share steps to create a UIImage with color space
kCGColorSpaceModelIndexed? (so I can test it) m = cv::Scalar(0);is this the correct way to handle the casealphaExist == true? (or is it just copy/pasted from thekCGColorSpaceModelMonochromeblock)- are there any other color spaces that should be handled by this function?
Thanks
Contributor
Author
|
Thank you for reviewing. I created UIImage on swift from https://en.wikipedia.org/wiki/Indexed_color. I copy/pasted from not kCGColorSpaceModelMonochrome block but else block I think this function has no problem now for other color spaces. |
Contributor
|
@okamotoR ありがとう！ |
Contributor
Author
|
Thank you very much. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UIImageToMat() fail to convert indexed color image now.
This is because CGBitmapContextCreate() in UIImageToMat() don't support indexed color spaces.
I added if block for indexed color spaces.
CGBitmapContextCreate
https://developer.apple.com/documentation/coregraphics/1455939-cgbitmapcontextcreate?language=objc
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.