Optim: test that could be done once has been extracted from the loop#17613
Closed
pemmanuelviel wants to merge 1 commit intoopencv:masterfrom
Closed
Optim: test that could be done once has been extracted from the loop#17613pemmanuelviel wants to merge 1 commit intoopencv:masterfrom
pemmanuelviel wants to merge 1 commit intoopencv:masterfrom
Conversation
Contributor
Author
|
Nowadays compiler should handle similarly both versions. However, checking quickly the assembly code obtained from an online tool between both versions, it looks like it might not be the case. So I've preferred to ensure a single evaluation of the condition whatever the compiler efficiency. |
6 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.