Skip to content

Pev fixes and clean#17612

Closed
pemmanuelviel wants to merge 8 commits intoopencv:masterfrom
pemmanuelviel:pev-fixes-and-clean
Closed

Pev fixes and clean#17612
pemmanuelviel wants to merge 8 commits intoopencv:masterfrom
pemmanuelviel:pev-fixes-and-clean

Conversation

@pemmanuelviel
Copy link
Copy Markdown
Contributor

@pemmanuelviel pemmanuelviel commented Jun 22, 2020

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Either we don't want this method to be used in the future for any other node
than the root node, and so we replace indices_length by size_ and remove it as
argument, or we want to be able to use it potentially for other nodes, and
so using size_ instead of indices_length would have lead to a bug.
…om Adil Ibragimov

Avoids trying to compute log(ratio) with ratio = 0
@pemmanuelviel
Copy link
Copy Markdown
Contributor Author

Asides from some fixes I've made parsing the code, I've also ported some from the original FLANN repo from Marius Muja.

@pemmanuelviel pemmanuelviel mentioned this pull request Jun 29, 2020
6 tasks
@alalek alalek mentioned this pull request Jun 29, 2020
@pemmanuelviel pemmanuelviel deleted the pev-fixes-and-clean branch July 2, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant