Skip to content

Disabling default NMS in yolo layer#17592

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
l-bat:disable_nms_in_yolo_layer
Jun 22, 2020
Merged

Disabling default NMS in yolo layer#17592
opencv-pushbot merged 1 commit intoopencv:3.4from
l-bat:disable_nms_in_yolo_layer

Conversation

@l-bat
Copy link
Copy Markdown
Contributor

@l-bat l-bat commented Jun 19, 2020 •
edited
Loading

Pull Request Readiness Checklist

resolve: #17415

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2020.3.0:16.04
build_image:Custom Win=openvino-2020.2.0
build_image:Custom Mac=openvino-2020.2.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*YOLO*

@l-bat l-bat added this to the 3.4.11 milestone Jun 19, 2020
@l-bat l-bat requested a review from dkurt June 19, 2020 11:36
@l-bat l-bat linked an issue Jun 19, 2020 that may be closed by this pull request
spurious NMS in region layer which is not compatible with darknet #17415
Closed
4 tasks
dkurt
dkurt previously approved these changes Jun 19, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@dkurt dkurt self-assigned this Jun 19, 2020
dkurt
dkurt approved these changes Jun 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like failed tests are not related to changes in this PR but exist only for specific configuration:

[  FAILED  ] Test_Darknet_nets.YOLOv4/3, where GetParam() = DLIE/OCL_FP16
[  FAILED  ] Test_Darknet_nets.YOLOv4/7, where GetParam() = NGRAPH/OCL_FP16

@l-bat l-bat changed the title Disabling dafault NMS in yolo layer Disabling default NMS in yolo layer Jun 22, 2020
@opencv-pushbot opencv-pushbot merged commit fce486c into opencv:3.4 Jun 22, 2020
@l-bat l-bat mentioned this pull request Jun 22, 2020
Closed
4 tasks
@alalek alalek mentioned this pull request Jun 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

spurious NMS in region layer which is not compatible with darknet

3 participants

@l-bat @dkurt @opencv-pushbot