Skip to content

CUDA: fix build error on Jetson TX1 and TX2#17581

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
tomoaki0705:fixCudaAsync
Jun 18, 2020
Merged

CUDA: fix build error on Jetson TX1 and TX2#17581
opencv-pushbot merged 1 commit intoopencv:3.4from
tomoaki0705:fixCudaAsync

Conversation

@tomoaki0705
Copy link
Copy Markdown
Contributor

@tomoaki0705 tomoaki0705 commented Jun 18, 2020

relates #17556

opencv/modules/cudaimgproc/src/cuda/canny.cu(110): warning: "override" and "final" are C++11 features
opencv/modules/cudaimgproc/src/cuda/canny.cu(131): error: namespace "std" has no member "enable_if_t"

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@tomoaki0705
fix build error on Jetson TX1 and TX2
c07af09 
 * enable_if_t and is_base_of is c++14 feature
 * override is c++11 feature
@nglee
Copy link
Copy Markdown
Contributor

nglee commented Jun 18, 2020

I think latest JetPack for TX1 and TX2 supports Ubuntu 18.04, which, in turn, is bundled with g++ 7.4.0.

To support older versions of g++, where c++14 standard is not a default option, can't we just add relevant flag for nvcc, or g++?

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jun 18, 2020

@nglee OpenCV team maintains 3.4 as C++03 compatible branch. C++11 is default for master.

@nglee
Copy link
Copy Markdown
Contributor

nglee commented Jun 18, 2020

@asmorkalov OK, I get it. Thank you.

alalek
alalek approved these changes Jun 18, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit a7cdc42 into opencv:3.4 Jun 18, 2020
This was referenced Jun 18, 2020
Merged
Merged
@tomoaki0705 tomoaki0705 deleted the fixCudaAsync branch June 18, 2020 21:36
@tomoaki0705 tomoaki0705 mentioned this pull request Jun 18, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug category: build/install category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

5 participants

@tomoaki0705 @nglee @asmorkalov @alalek @opencv-pushbot