Skip to content

cudacodec(build): fix detection in CMake, cleanup duplicate includes#17568

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:cleanup_17527
Jun 18, 2020
Merged

cudacodec(build): fix detection in CMake, cleanup duplicate includes#17568
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:cleanup_17527

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Jun 17, 2020 •
edited
Loading

relates #17527
resolves #17559

Common includes should be handled by precomp.hpp

/cc @tomoaki0705

force_builders=Custom
buildworker:Custom=linux-4
build_image:Custom=ubuntu-cuda:18.04

@tomoaki0705
Copy link
Copy Markdown
Contributor

tomoaki0705 commented Jun 17, 2020

I'll have a look. Basically seems OK.

@tomoaki0705
Copy link
Copy Markdown
Contributor

tomoaki0705 commented Jun 17, 2020

It passed the build on my Jetson Xavier.
Other Jetsons are occupied for now and waiting result.
The patch looks good to me

@alalek
Copy link
Copy Markdown
Member Author

alalek commented Jun 18, 2020

👍

@opencv-pushbot opencv-pushbot merged commit 42a4c3f into opencv:3.4 Jun 18, 2020
This was referenced Jun 18, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alalek alalek

Labels

category: build/install category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

Build error for opencv-3.4.10 on Ubuntu18.04 with CUDA 10.1

3 participants

@alalek @tomoaki0705 @opencv-pushbot