Skip to content

fixed #17044#17436

Merged
alalek merged 4 commits intoopencv:3.4from
vpisarev:fix_python_io
Jun 1, 2020
Merged

fixed #17044#17436
alalek merged 4 commits intoopencv:3.4from
vpisarev:fix_python_io

Conversation

@vpisarev
Copy link
Copy Markdown
Contributor

@vpisarev vpisarev commented May 30, 2020

fixes #17044

  1. fixed Python part of the tutorial about using OpenCV XML-YAML-JSON I/O functionality from C++ and Python.
  2. added startWriteStruct() and endWriteStruct() methods to FileStorage
  3. modifed FileStorage::write() methods to make them work well inside sequences, not only mappings.

it seems that in master branch just the tutorial should be fixed and CV_WRAP should be added to already existing startWriteStruct() and endWriteStruct() declarations in FileStorage class. Then everything works out of the box. But I can check it as soon as the patch gets merged into master and submit another master-specific patch, if needed.

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

vpisarev added 2 commits May 31, 2020 01:42
1. fixed Python part of the tutorial about using OpenCV XML-YAML-JSON I/O functionality from C++ and Python.
2. added startWriteStruct() and endWriteStruct() methods to FileStorage
3. modifed FileStorage::write() methods to make them work well inside sequences, not only mappings.
@alalek
Copy link
Copy Markdown
Member

alalek commented May 31, 2020

It would be nice to have Python automatic test (which writes FileStorage into string and check its content).

@vpisarev
Copy link
Copy Markdown
Contributor Author

done

@alalek alalek merged commit 5489735 into opencv:3.4 Jun 1, 2020
@alalek alalek mentioned this pull request Jun 4, 2020
@vpisarev vpisarev deleted the fix_python_io branch July 10, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug category: core category: python bindings Hackathon https://opencv.org/opencv-hackathon-starts-next-week/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants